Abstract：The study and discovery of more ore-forming environments and rock formations are conducive to expanding the exploratory field and enhancing the ore prospecting efficiency. Based on the regional metallogenic features of China, the author proposes some ore-forming environments that we should pay more attention to recently. Major features of regional metallogeny of China are as follows：① many ore deposits are concentrated on the margins of the old land；② multi-stage mineralization is well developed；③ superimposition and modification of mineralization are pronounced；④ hydrothermal ore deposits are abundant and diverse；⑤ organic mineralization and inorganic mineralization are combined；⑥ conditions for changes and preservation after the formation of ore deposits are complex.The ore-forming geological environments and rock formations which have high ore potential and in which some findings may be made include：① black shale series； ② melanocratic rock series,；③ composite sedimentary basins；④compounding of ancient lake basins and tectono-magmatic belts；⑤ multiple forms of superimposition mineralization； ⑥ time and space of transition of tectonic systems,；⑦ ore potential of geochemical blocks,；⑧ exploration of deep ore deposits and vertical zoning of mineralization. At last the author suggests some methods and ways to discover new ore deposits in China.